Skip to content
Snippets Groups Projects
  1. Mar 02, 2021
  2. Nov 21, 2020
  3. Jun 05, 2020
  4. May 29, 2020
  5. May 26, 2020
  6. May 18, 2020
    • Lorenzo Moneta's avatar
      Fix multithread fitting in case of ThnSparse and bin integral fits (#5626) · 9daf978e
      Lorenzo Moneta authored
      * Fix case when ROOT is running with MT and TVIrtualFitter pointer to last fitter is not present
      
      * Fix multithread fitting when computing a bin intengral or re-normalizing by the bin volume (case of Thnsparse fit).
      The fix is applied for both least-square and binned likelihood fit
      
      Improve stressHistoFit test.
      Add option "-t" to run in multi-thread mode.
      Add the option X for fitting to make sure chi2 method is run
      
      Now all stresshistofit tests pass in multi-thread mode.
      Note that when computing integral in multi-thread only the GuassIntegrator of mathcore is thread safe for 1D. Also the AdaptiveIntegratorMultiDim, used in the multi-dim case, is thread safe.
      
      * Remove non-thread safe access to BinData::BinEdge also in other fitting functions and replace them with the thread safe version
      9daf978e
  7. May 11, 2020
  8. May 05, 2020
  9. May 04, 2020
  10. Apr 02, 2020
  11. Mar 31, 2020
  12. Mar 27, 2020
  13. Mar 18, 2020
  14. Mar 10, 2020
  15. Mar 02, 2020
  16. Feb 14, 2020
  17. Feb 12, 2020
  18. Jan 30, 2020
  19. Jan 29, 2020
  20. Jan 28, 2020
    • Sergey Linev's avatar
    • Bertrand Bellenot's avatar
      c97a5423
    • Bertrand Bellenot's avatar
      Fix compilation of math/mathmore/test/StatFunction.cxx · f77848e5
      Bertrand Bellenot authored
      This patch fixes the compilation of math/mathmore/test/StatFunction.cxx, but whith the `win_broken_tests` flag, the test-stressmathmore-interpreted fails with the followin errors:
      
      193: Processing C:/Users/bellenot/git/master/test/stressMathMore.cxx...
      193: In file included from C:\Users\bellenot\build\debug\input_line_11:15:
      193: In file included from C:\Users\bellenot\build\debug\etc\dictpch\allHeaders.h:943:
      193: C:/Users/bellenot/build/debug\include\Math/Functor.h:181:9: error: virtual function 'Clone' has a different return type ('auto') than the function it overrides (which has return type 'ROOT::Math::IBaseFunctionOneDim *')
      193:    auto Clone() const { return Copy(); }
      193:    ~~~~ ^
      193: C:/Users/bellenot/build/debug\include\Math/Functor.h:731:17: note: in instantiation of template class 'ROOT::Math::FunctorGradHandler<ROOT::Math::GradFunctor1D, InvFunc, StatFunction>' requested here
      193:       fImpl(new FunctorGradHandler<GradFunctor1D,Func, GradFunc>(f, g) )
      193:                 ^
      193: C:\Users\bellenot\git\master\test\stressMathMore.cxx:405:21: note: in instantiation of function template specialization 'ROOT::Math::GradFunctor1D::GradFunctor1D<InvFunc, StatFunction>' requested here
      193:       GradFunctor1D func(finv,*this);
      193:                     ^
      193: C:\Users\bellenot\build\debug\include\Math\IFunction.h:152:39: note: overridden virtual function is here
      193:          virtual IBaseFunctionOneDim *Clone() const = 0;
      193:                  ~~~~~~~~~~~~~~~~~~~~~^
      193: CMake Error at C:/Users/bellenot/build/debug/RootTestDriver.cmake:241 (message):
      193:   error code: 1
      193:
      193:
      2/2 Test #193: test-stressmathmore-interpreted ...***Failed    4.45 sec
      f77848e5
    • Bertrand Bellenot's avatar
      Allow to run broken tests on Windows & add `FIXME` comments · 6011dc5c
      Bertrand Bellenot authored
      - Add a CMake flag (win_broken_tests) to enable broken tests on Windows
      - Add a couple of `FIXME` comments, for the following errors:
        - In TSystem::GetIncludePath(), with ACLiC:
          input_line_12:8:38: error: use of undeclared identifier 'IC'
          "C:/Users/bellenot/build/debug/etc" -IC:/Users/bellenot/build/debug/etc//cling -IC:/Users/bellenot/build/debug/include"",
                                               ^
          Error in <ACLiC>: Dictionary generation failed!
        - When compiling math/mathmore/test/StatFunction.cxx, it generates those errors:
          Math/Functor.h(182): error C2059: syntax error: '<'
          Math/Functor.h(182): error C2947: expecting '>' to terminate template-argument-list, found '<'
          Math/Functor.h(182): error C2062: type 'unknown-type' unexpected
          Math/Functor.h(181,-1847264676) : error C2039: 'Clone': is not a member of '`global namespace''
          Math/Functor.h(182): error C2143: syntax error: missing ';' before '{'
          Math/Functor.h(182): error C2447: '{': missing function header (old-style formal list?)
          Math/Functor.h(182): error C2059: syntax error: '<'
          Math/Functor.h(182): error C2947: expecting '>' to terminate template-argument-list, found '<'
          Math/Functor.h(182): error C2062: type 'unknown-type' unexpected
          Math/Functor.h(181,-1847263020) : error C2039: 'Clone': is not a member of '`global namespace''
          Math/Functor.h(182): error C2143: syntax error: missing ';' before '{'
          Math/Functor.h(182): error C2447: '{': missing function header (old-style formal list?)
      6011dc5c
    • Bertrand Bellenot's avatar
      Fix several tests on Windows · e720e2af
      Bertrand Bellenot authored
      - Add a couple of missing symbols into the export list
      - Fix several test failing on Windows, mostly due to files staying open (creates file access issues on Windows)
      - Filter-out several unsupported tests (will add them back once the underlying issues are fixed)
      e720e2af
  21. Jan 14, 2020
Loading