Skip to content
Snippets Groups Projects
  1. Jun 23, 2020
  2. May 04, 2020
  3. Apr 27, 2020
  4. Apr 20, 2020
  5. Mar 28, 2020
  6. Mar 27, 2020
  7. Mar 02, 2020
  8. Feb 28, 2020
  9. Feb 20, 2020
  10. Feb 15, 2020
  11. Jan 30, 2020
  12. Jan 29, 2020
  13. Dec 21, 2019
  14. Oct 23, 2019
    • Philippe Canal's avatar
      Remove redundant check in proof · 7224d0c4
      Philippe Canal authored
      7224d0c4
    • Philippe Canal's avatar
      Prevent nullptr derefence in Proof. · ba081579
      Philippe Canal authored
      V595 The 'fPlayer' pointer was utilized before it was verified against nullptr. Check lines: 3425, 3430. TProof.cxx 3425
      V595 The 'gProofServ' pointer was utilized before it was verified against nullptr. Check lines: 1192, 1194. TProofPlayer.cxx 1192
      ba081579
    • Philippe Canal's avatar
      In TProofServ HandleSocketInput, HandleProcess fix incorrect error check. · fe428c62
      Philippe Canal authored
      V593 Consider reviewing the expression of the 'A = B < C' kind. The expression is calculated as following: 'A = (B < C)'. TProofServ.cxx 1903
      V593 Consider reviewing the expression of the 'A = B < C' kind. The expression is calculated as following: 'A = (B < C)'. TProofServ.cxx 3897
      
      This bug reveals itself only in the case of the program's faulty behavior. The ret variable is supposed to store the return code of the AddWorkers function and write that value to the log in case of error condition. But it doesn't work as intended. The condition lacks additional parentheses forcing the desired order of evaluation. What the ret variable actually stores is not the return code but the result of the logical comparison, i.e. either 0 or 1.
      fe428c62
    • Philippe Canal's avatar
      Attempt to fix indentical condition in TProofMonSenderML::SendSummary. · 3c76d13b
      Philippe Canal authored
      V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 163, 165. TProofMonSenderML.cxx 163
      3c76d13b
    • Philippe Canal's avatar
      Adding missing else keyword. · 1438a094
      Philippe Canal authored
      V646 Consider inspecting the application's logic. It's possible that 'else' keyword is missing. TProofServ.cxx 729
      V646 Consider inspecting the application's logic. It's possible that 'else' keyword is missing. TFormula_v5.cxx 3702
      V646 Consider inspecting the application's logic. It's possible that 'else' keyword is missing. RooAbsCategory.cxx 604
      1438a094
  15. Oct 11, 2019
  16. Aug 16, 2019
  17. Jul 01, 2019
  18. Jun 05, 2019
  19. May 14, 2019
  20. Mar 12, 2019
  21. Feb 18, 2019
  22. Feb 05, 2019
Loading