Skip to content
Snippets Groups Projects
  1. Oct 19, 2020
  2. Sep 30, 2020
  3. Jul 24, 2020
    • Lorenzo Moneta's avatar
      Fix a bug in computation of Minos errors when a parameter is bounded (#5899) (#6060) · 393f8a21
      Lorenzo Moneta authored
      * Fix computation of Minos errrors in Minuit2 when parameters are bounded.
      A bug was introduced when the conditions "new minimum found" was added in Minos.
      (ROOT-10854)
      
      Add some fixes also the message reporting in Minuit2. Restore usage of ROOT message reporting system when MInuit2 is built within ROOT
      
      * Add a protection in TMinuit to avoid a 0/0 division. Fix ROOT-10835
      This can happen when parameter limit is 0 and parameter value at minimum is 0
      and a Minos error analysis is performed for that parameter.
      
      * Fix running Minos error when a new minimum is found.
      Fix the handling of the situation of Minos error in Minuit2 when a new minimum is found.
      Add a function in the Minimizer to get the status code of Minos to flag when a new minimum is found
      Fix function returning minimum values in Minuit2Minimizer in case of multiple runs. The minimum values are now copied in the Mininuit2Minimizer local vector when the minimization is run
      
      * Update Fitter::CalculateMinosError when a new minimum is found in Minos
      Recompute the minos error for the previous run parameter in case a new minimum was found
      
      * Use fabs instead of abs. Fix problem reported by CI builds
      
      * small fixes in documentation as suggested by Stephan's review
      
      * Revert changes in the Minuit2 CMAKE file for enabling Minuit2 error and warning messages.
      These changes will be done in a separate commit and  a new PR.
  4. May 18, 2020
    • Lorenzo Moneta's avatar
      Fix multithread fitting in case of ThnSparse and bin integral fits (#5626) · 9daf978e
      Lorenzo Moneta authored
      * Fix case when ROOT is running with MT and TVIrtualFitter pointer to last fitter is not present
      
      * Fix multithread fitting when computing a bin intengral or re-normalizing by the bin volume (case of Thnsparse fit).
      The fix is applied for both least-square and binned likelihood fit
      
      Improve stressHistoFit test.
      Add option "-t" to run in multi-thread mode.
      Add the option X for fitting to make sure chi2 method is run
      
      Now all stresshistofit tests pass in multi-thread mode.
      Note that when computing integral in multi-thread only the GuassIntegrator of mathcore is thread safe for 1D. Also the AdaptiveIntegratorMultiDim, used in the multi-dim case, is thread safe.
      
      * Remove non-thread safe access to BinData::BinEdge also in other fitting functions and replace them with the thread safe version
  5. May 14, 2020
  6. May 11, 2020
  7. May 06, 2020
  8. May 05, 2020
    • Lorenzo Moneta's avatar
      Update the TMatrix documentations. · 87d8ffa2
      Lorenzo Moneta authored
      Add a new page (doc/Matrix.md)describing TMatrix combining the Web module documentation with the pre-existing ones.
      Reference the new matrix page from the TMatrix,TMatrixTBase, TMatrixTSym and TVectorT refeence class documentation
      87d8ffa2
  9. May 04, 2020
  10. May 01, 2020
    • Oksana Shadura's avatar
      Update gtest to latest version 1.10.0 (#5228) · b03e4ae7
      Oksana Shadura authored
      * Update gtest to latest version 1.10.0
      
      More info: https://github.com/google/googletest/releases/tag/release-1.10.0
      
      * Adjust cmake variables to be used by Ninja of build byproducts
      
      * Replace deprecated functions for googletest 1.10 release
      
      * Add missing gtest_main target
      
      * Fix locations for gtest and gtest_main targets
      
      * Update CMake configuration for gtest tests
      
      Tests were failing with next error: /usr/bin/ld: ../../../googletest-prefix/src/googletest-build/lib/libgtest_main.a(gtest_main.cc.o): in function testing::InitGoogleTest(int*, char**)
      /usr/bin/ld: gtest_main.cc:(.text.startup+0x2f): undefined reference to testing::UnitTest::Run()
      
      * Patch by Bertrand Bellenot: Update build configuration for Windows
      
      * We build googletest in Release mode (for Debug names of libraries should be different and require special treatment)
      
      * [formating] Add EOL in CMakeLists.txt
  11. Apr 30, 2020
  12. Apr 27, 2020
  13. Apr 23, 2020
  14. Apr 22, 2020
  15. Apr 21, 2020
  16. Apr 16, 2020
    • Alexander Voigt's avatar
      correcting incorrectly rounded coefficient in dilogarithm · 929c8e24
      Alexander Voigt authored
      expansion in terms of Chebyshev polynomials.
      
      Compare with [Yudell L. Luke: Mathematical functions and their
      approximations, Academic Press Inc., New York 1975, p.67, Table 3.12]:
      
       0.42996693560813697204
       0.40975987533077105847
      -0.01858843665014591965
       0.00145751084062267855
      -0.00014304184442340049
       0.00001588415541879553
      -0.00000190784959386583
       0.00000024195180854165
      -0.00000003193341274252
       0.00000000434545062677
      -0.00000000060578480118
       0.00000000008612097799
      -0.00000000001244331660
       0.00000000000182255696
      -0.00000000000027006766
       0.00000000000004042209
      -0.00000000000000610325
       0.00000000000000092863
      -0.00000000000000014226
       0.00000000000000002193
      -0.00000000000000000340
       0.00000000000000000053
      -0.00000000000000000008
       0.00000000000000000001
      
      On IEEE-conforming platforms this change does not have any numerical
      effect, because the two floating point numbers
      
         double x = 0.40975987533077105;
         double y = 0.40975987533077106;
      
      have the same binary representation at double precision.
      929c8e24
  17. Apr 11, 2020
  18. Apr 09, 2020
  19. Apr 08, 2020
    • Vassil Vassilev's avatar
      [math] Do not warn if len is unused. · 78433bdf
      Vassil Vassilev authored
      This fixes a nightly build issue on OSX with -Druntime_cxxmodules=On by default.
      There rootcling still needs to parse the assert statement even if NDEBUG is
      defined.
      78433bdf
  20. Apr 06, 2020
  21. Mar 26, 2020
  22. Mar 16, 2020
  23. Mar 10, 2020
  24. Mar 02, 2020
  25. Feb 28, 2020
Loading