Now that we need to distinguish x86_64 from arm. Also "macOS" version is not
necessarily "X" anymore.

(cherry picked from commit 435006bed82e030af23746f989ac94d901165217)

BUILD_TYPE has a different meaning, use a local variable instead.

(cherry picked from commit 075e1de742fe47916f516e7efe7123a4c40e0805)

The framework one depends on https://github.com/root-project/root/issues/6753
and https://gitlab.kitware.com/cmake/cmake/-/issues/21293
before we can potentially use it. And anyway if users install their own
Python we should be nice and use that, not Python coming with Xcode / cmd line tools.

Works around:
dlopen(/Users/sftnight/build/jenkins/night/LABEL/mac10beta/SPEC/cxx17/V/master/build/lib/libROOTTPython.so, 9): Library not loaded: @rpath/Python3.framework/Versions/3.8/Python3
  Referenced from: /Users/sftnight/build/jenkins/night/LABEL/mac10beta/SPEC/cxx17/V/master/build/lib/libROOTTPython.so
  Reason: image not found

silence warning "include <gsl/... - you meant <GSL/...?" by renaming source dir.

This is mostly to make anti-virus (virustotal.com) happy with Windows binaries and prevent false positives. But it is also nice to have proper ROOT icon and meta-information in the executables themselves

Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch>

Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch>

In Ubuntu snap chrome version is used and it does not correctly
translate command line arguments, making problem to use it in batch.
Error already communicated by Axel:
https://bugs.launchpad.net/ubuntu/+source/snap/+bug/1893020
Once it is fixed, this commit can be reverted

The old client library libXrdClient is removed.
Also XrdSysDNS is removed.

Do not build the legacy XProofD file server and client (already
disabled by default - give error if someone enables it while building
with xrootd 5).

Do not build the old libNetx.

Build the new libNetNG without XrdSysDNS, use XrdNetAddr instead.

When building with one Python, PYTHON_VERSION_STRING_Development_Other
is not defined.

In some cases, the dictionary generation fails on Windows with character missing in the header file names, or in the path when there is a long list of headers.
For example, with TMVA, the dictionary generation was failing with the weird missing characters errors, like for example:

  Generating G__TMVA.cxx, ../../bin/libTMVA_rdict.pcm, ../../bin/libTMVA.rootmap
  <<< cling interactive line includer >>>:164:10: fatal error: 'TMVA/Volume.' file not found
  #include "TMVA/Volume."
           ^~~~~~~~~~~~~~
Or:

  Generating G__TMVA.cxx, ../../bin/libTMVA_rdict.pcm, ../../bin/libTMVA.rootmap
  input_line_12:168:10: fatal error: 'TMV/Version.h' file not found
  #include "TMV/Version.h"
           ^~~~~~~~~~~~~~~
Or again:

  Generating G__TMVA.cxx, ../../bin/libTMVA_rdict.pcm, ../../bin/libTMVA.rootmap
  input_line_12:170:10: fatal error: 'TMVA/TreInference/Objectives.hxx' file not found
  #include "TMVA/TreInference/Objectives.hxx"
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This is coming from a recent change in include path, when it moved from the unique `root/include` directory to the multiple source `module/inc` directories, making a long list of (for example) `-IC:/Users/bellenot/git/master/core/winnt/inc`, with many duplicates, making a command of more than 8000 characters
Removing the (many) duplicates is enough to fix the issue.

So on Windows, we now require CMake vesrion 3.16 for the following reasons:
 - 3.15: Added $<REMOVE_DUPLICATES:list> generator expression
 - 3.16: Bug fix with CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS: the auto-generated exports are now updated only when the object files providing the symbols are updated, fixing the incremental build

(it's easy to update CMake on Windows)

rootcling uses modules, and those have a modulemap entry for include/RConfigure.h.
Make sure that it actually gets copied before the first run of rootcling.

If we don't cache the PyROOT library, include dir and version
variables, they will not be found by CMake in the loop over
CACHE_VARIABLES which sets ROOT_CONFIGARGS in the main CMakeLists.txt,
and therefore root-config --config will not show them.

Had to make sure that the GSL_CBLAS_LIBRARY variable is set in the
same way in which FindGSL.cmake would set it, and that TMVA would
explicitly wait for the completion of the GSL build.

A fix for:
https://lcgapp-services.cern.ch/root-jenkins/job/roottest-pullrequests-build/6686/console